Don't commit for read-only query #44905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
Dec 13, 2024
|
Why are those things failing… |
uranusjr
force-pushed
the
no-create-session-in-resolve-asset
branch
from
98becc2 to
064cede
Compare
|
I don’t know why it failed, but I found a way that works. |
uranusjr
force-pushed
the
no-create-session-in-resolve-asset
branch
from
064cede to
95f7443
Compare
This does not use the create_session/provide_session/NEW_SESSION paradigm because it requires importing them globally, which is not allowed in the SDK. We also do not want to create a session unless absolutely needed.
uranusjr
force-pushed
the
no-create-session-in-resolve-asset
branch
from
95f7443 to
6ccc74a
Compare
ephraimbuddy
approved these changes
Dec 13, 2024
shahar1
approved these changes
Dec 13, 2024
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Don't commit for read-only query * Pass session from outside when we can This does not use the create_session/provide_session/NEW_SESSION paradigm because it requires importing them globally, which is not allowed in the SDK. We also do not want to create a session unless absolutely needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.